DLPLAT-999/handling-errors: Errors were not being reported correctly (#23)

ericvautour-quandl · web-flow · commit 859131bc0924 · 2022-08-09T13:10:56.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 1.0.3 - 2022-08-07
+
+* Fixes an issue with errors not being reported correctly.
+
 ### 1.0.2 - 2022-05-02
 
 * Fixes an issue with sessions not respecting proxy settings.
diff --git a/nasdaqdatalink/connection.py b/nasdaqdatalink/connection.py
@@ -97,11 +97,11 @@ def handle_api_error(cls, resp):
 
         # if our app does not form a proper data_link_error response
         # throw generic error
-        if 'error' not in error_body:
+        if 'quandl_error' not in error_body:
             raise DataLinkError(http_status=resp.status_code, http_body=resp.text)
 
-        code = error_body['error']['code']
-        message = error_body['error']['message']
+        code = error_body['quandl_error']['code']
+        message = error_body['quandl_error']['message']
         prog = re.compile('^QE([a-zA-Z])x')
         if prog.match(code):
             code_letter = prog.match(code).group(1)
diff --git a/nasdaqdatalink/version.py b/nasdaqdatalink/version.py
@@ -1 +1 @@
-VERSION = '1.0.2'
+VERSION = '1.0.3'
diff --git a/test/test_connection.py b/test/test_connection.py
@@ -35,7 +35,7 @@ def test_nasdaqdatalink_exceptions_no_retries(self, request_method):
         httpretty.register_uri(getattr(httpretty, request_method),
                                "https://data.nasdaq.com/api/v3/databases",
                                responses=[httpretty.Response(body=json.dumps(
-                                   {'error':
+                                   {'quandl_error':
                                     {'code': x[0], 'message': 'something went wrong'}}),
                                    status=x[1]) for x in data_link_errors]
                                )
diff --git a/test/test_database.py b/test/test_database.py
@@ -179,7 +179,7 @@ def test_bulk_download_raises_exception_when_error_response(self):
                                re.compile(
                                    'https://data.nasdaq.com/api/v3/databases/*'),
                                body=json.dumps(
-                                   {'error':
+                                   {'quandl_error':
                                     {'code': 'QEMx01', 'message': 'something went wrong'}}),
                                status=500)
 
diff --git a/test/test_datatable.py b/test/test_datatable.py
@@ -186,7 +186,7 @@ def test_bulk_download_table_raises_exception_when_error_response(self, request_
         ApiConfig.number_of_retries = 2
         error_responses = [httpretty.Response(
             body=json.dumps(
-              {'error': {'code': 'QEMx01', 'message': 'something went wrong'}}
+              {'quandl_error': {'code': 'QEMx01', 'message': 'something went wrong'}}
             ),
             status=500)]
 
diff --git a/test/test_retries.py b/test/test_retries.py
@@ -39,7 +39,7 @@ def setUpClass(cls):
 
         cls.error_response = httpretty.Response(
             body=json.dumps(
-              {'error': {'code': 'QEMx01', 'message': 'something went wrong'}}
+              {'quandl_error': {'code': 'QEMx01', 'message': 'something went wrong'}}
             ),
             status=500)
         cls.success_response = httpretty.Response(body=json.dumps(cls.datatable), status=200)

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ def test_nasdaqdatalink_exceptions_no_retries(self, request_method):`
`35`	`35`	`httpretty.register_uri(getattr(httpretty, request_method),`
`36`	`36`	`"https://data.nasdaq.com/api/v3/databases",`
`37`	`37`	`responses=[httpretty.Response(body=json.dumps(`
`38`		`- {'error':`
	`38`	`+ {'quandl_error':`
`39`	`39`	`{'code': x[0], 'message': 'something went wrong'}}),`
`40`	`40`	`status=x[1]) for x in data_link_errors]`
`41`	`41`	`)`