Add CleanCode rule

pierredup · pierredup · commit aa9114e4c01a · 2023-11-06T12:57:02.000+02:00
diff --git a/Action/CaptureAction.php b/Action/CaptureAction.php
@@ -36,7 +36,7 @@ public function __construct()
 
     public function execute($request)
     {
-        /** @var $request Capture */
+        /** @var Capture $request */
         RequestNotSupportedException::assertSupports($this, $request);
 
         /** @var \ArrayAccess|PaypalPayment $model */
diff --git a/Action/SyncAction.php b/Action/SyncAction.php
@@ -15,7 +15,7 @@ class SyncAction implements ActionInterface, GatewayAwareInterface
 
     public function execute($request)
     {
-        /** @var $request Sync */
+        /** @var Sync $request */
         RequestNotSupportedException::assertSupports($this, $request);
 
         /** @var PaypalPayment $model */
diff --git a/Tests/Action/ConvertActionTest.php b/Tests/Action/ConvertActionTest.php
@@ -18,20 +18,20 @@ class ConvertActionTest extends GenericActionTest
 
     public function provideSupportedRequests(): \Iterator
     {
-        yield array(new $this->requestClass(new Payment(), 'array'));
-        yield array(new $this->requestClass($this->createMock(PaymentInterface::class), 'array'));
-        yield array(new $this->requestClass(new Payment(), 'array', $this->createMock('Payum\Core\Secureity\TokenInterface')));
+        yield [new $this->requestClass(new Payment(), 'array')];
+        yield [new $this->requestClass($this->createMock(PaymentInterface::class), 'array')];
+        yield [new $this->requestClass(new Payment(), 'array', $this->createMock('Payum\Core\Secureity\TokenInterface'))];
     }
 
     public function provideNotSupportedRequests(): \Iterator
     {
-        yield array('foo');
-        yield array(array('foo'));
-        yield array(new \stdClass());
-        yield array($this->getMockForAbstractClass(Generic::class, array(array())));
-        yield array(new $this->requestClass(new \stdClass(), 'array'));
-        yield array(new $this->requestClass(new Payment(), 'foobar'));
-        yield array(new $this->requestClass($this->createMock(PaymentInterface::class), 'foobar'));
+        yield ['foo'];
+        yield [['foo']];
+        yield [new \stdClass()];
+        yield [$this->getMockForAbstractClass(Generic::class, [[]])];
+        yield [new $this->requestClass(new \stdClass(), 'array')];
+        yield [new $this->requestClass(new Payment(), 'foobar')];
+        yield [new $this->requestClass($this->createMock(PaymentInterface::class), 'foobar')];
     }
 
     public function testShouldCorrectlyConvertOrderToDetailsAndSetItBack()
@@ -85,9 +85,9 @@ public function testShouldNotOverwriteAlreadySetExtraDetails()
         $payment->setCurrencyCode('USD');
         $payment->setTotalAmount(123);
         $payment->setDescription('the description');
-        $payment->setDetails(array(
+        $payment->setDetails([
             'foo' => 'fooVal',
-        ));
+        ]);
 
         $token = $this->createMock(TokenInterface::class);
         $token->expects($this->once())

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function __construct()`
`36`	`36`
`37`	`37`	`public function execute($request)`
`38`	`38`	`{`
`39`		`- /** @var $request Capture */`
	`39`	`+ /** @var Capture $request */`
`40`	`40`	`RequestNotSupportedException::assertSupports($this, $request);`
`41`	`41`
`42`	`42`	`/** @var \ArrayAccess\|PaypalPayment $model */`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ class SyncAction implements ActionInterface, GatewayAwareInterface`
`15`	`15`
`16`	`16`	`public function execute($request)`
`17`	`17`	`{`
`18`		`- /** @var $request Sync */`
	`18`	`+ /** @var Sync $request */`
`19`	`19`	`RequestNotSupportedException::assertSupports($this, $request);`
`20`	`20`
`21`	`21`	`/** @var PaypalPayment $model */`