Two sum #1226
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // https://leetcode.com/problems/two-sum/ | ||
|
|
||
| // Given an array of integers, return indices of the two numbers such that they add up to | ||
| // a specific target. | ||
|
|
||
| // You may assume that each input would have exactly one solution, and you may not use the | ||
| // same element twice. | ||
|
|
||
| // Example: | ||
| // Given nums = [2, 7, 11, 15], target = 9, | ||
|
|
||
| // Because nums[0] + nums[1] = 2 + 7 = 9, | ||
| // return [0, 1]. | ||
|
|
||
| const TwoSum = (nums, target) => { | ||
|
There was a problem hiding this comment. That's a pretty naive implementation with a runtime of O(n²). Please document this in the JSDoc comment. There was a problem hiding this comment. Please see the docs and use the proper |
||
| for (let i = 0; i < nums.length; i++) { | ||
| for (let j = i + 1; j < nums.length; j++) { | ||
| if (nums[i] + nums[j] === target) { | ||
| return [i, j] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| export { TwoSum } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { TwoSum } from '../TwoSum' | ||
|
|
||
| describe('TwoSum tests', () => { | ||
| it('check that a variety of inputs return the correct answer', () => { | ||
|
There was a problem hiding this comment. Just use |
||
| expect(TwoSum([2, 7, 11, 15], 9)).toEqual([0, 1]) | ||
| expect(TwoSum([2, 7, 11, 15, 6], 8)).toEqual([0, 4]) | ||
| expect(TwoSum([1, 0, 5, 7, 3, 4], 6)).toEqual([0, 2]) | ||
| expect(TwoSum([0, 8, 3, 1, 2, 7, 3], 6)).toEqual([2, 6]) | ||
| expect(TwoSum([0, 5, 4, 2, 6, 7, 9, 1], 3)).toEqual([3, 7]) | ||
| }) | ||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to use a JSDoc comment right above the definition of
TwoSum?