Content-Length: 3250 | pFad | http://github.com/TheAlgorithms/JavaScript/pull/1606.patch

thub.com From 0fa3514ed0ad6ea41c94e2c71da3e5bf5bd166fc Mon Sep 17 00:00:00 2001 From: Piotr Idzik Date: Sat, 3 Feb 2024 12:21:10 +0000 Subject: [PATCH 1/3] tests: add missing tests for `PascalTriangle` --- Maths/test/PascalTriangle.test.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Maths/test/PascalTriangle.test.js b/Maths/test/PascalTriangle.test.js index 314d0f3211..c47a01233b 100644 --- a/Maths/test/PascalTriangle.test.js +++ b/Maths/test/PascalTriangle.test.js @@ -1,3 +1,4 @@ +import { expect } from 'vitest' import { generate } from '../PascalTriangle' describe('Pascals Triangle', () => { @@ -17,4 +18,19 @@ describe('Pascals Triangle', () => { expect.arrayContaining([[1], [1, 1], [1, 2, 1]]) ) }) + it.each([ + [0, []], + [1, [[1]]], + [2, [[1], [1, 1]]], + [3, [[1], [1, 1], [1, 2, 1]]], + [4, [[1], [1, 1], [1, 2, 1], [1, 3, 3, 1]]], + [5, [[1], [1, 1], [1, 2, 1], [1, 3, 3, 1]], [1, 4, 6, 4, 1]] + ])('check with %j', (input, expected) => { + const pascalsTriangle = generate(input) + expect(pascalsTriangle.length).toEqual(input) + pascalsTriangle.forEach((arr, index) => { + expect(arr.length).toEqual(index + 1) + }) + expect(pascalsTriangle).toEqual(expect.arrayContaining(expected)) + }) }) From 452f556b31d68631ac836c5f8403b24b222a896e Mon Sep 17 00:00:00 2001 From: Piotr Idzik Date: Sat, 3 Feb 2024 12:29:16 +0000 Subject: [PATCH 2/3] style: remove redundant branch in `generate` --- Maths/PascalTriangle.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/Maths/PascalTriangle.js b/Maths/PascalTriangle.js index 868e36fcac..71d782cd61 100644 --- a/Maths/PascalTriangle.js +++ b/Maths/PascalTriangle.js @@ -17,8 +17,6 @@ const generate = (numRows) => { return [] } else if (numRows === 1) { return [[1]] - } else if (numRows === 2) { - return [[1], [1, 1]] } else { for (let i = 2; i < numRows; i++) { addRow(triangle) From 760db436b2182d51e1e41d4210df5af077116be2 Mon Sep 17 00:00:00 2001 From: Piotr Idzik Date: Sat, 3 Feb 2024 12:33:58 +0000 Subject: [PATCH 3/3] tests: simplify tests of `PascalTriangle` --- Maths/test/PascalTriangle.test.js | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/Maths/test/PascalTriangle.test.js b/Maths/test/PascalTriangle.test.js index c47a01233b..65c736f14f 100644 --- a/Maths/test/PascalTriangle.test.js +++ b/Maths/test/PascalTriangle.test.js @@ -2,22 +2,6 @@ import { expect } from 'vitest' import { generate } from '../PascalTriangle' describe('Pascals Triangle', () => { - it('should have the the same length as the number', () => { - const pascalsTriangle = generate(5) - expect(pascalsTriangle.length).toEqual(5) - }) - it('should have same length as its index in the array', () => { - const pascalsTriangle = generate(5) - pascalsTriangle.forEach((arr, index) => { - expect(arr.length).toEqual(index + 1) - }) - }) - it('should return an array of arrays', () => { - const pascalsTriangle = generate(3) - expect(pascalsTriangle).toEqual( - expect.arrayContaining([[1], [1, 1], [1, 2, 1]]) - ) - }) it.each([ [0, []], [1, [[1]]],

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!