fix: throw error instead of returning it RailwayTimeConversion (TheAlgorithms#1625)

vil02 · web-flow · commit 894a46ca67ed · 2024-03-02T13:24:46.000+05:30
diff --git a/Conversions/RailwayTimeConversion.js b/Conversions/RailwayTimeConversion.js
@@ -18,7 +18,7 @@
 const RailwayTimeConversion = (timeString) => {
   // firstly, check that input is a string or not.
   if (typeof timeString !== 'string') {
-    return new TypeError('Argument is not a string.')
+    throw new TypeError('Argument is not a string.')
   }
   // split the string by ':' character.
   const [hour, minute, secondWithShift] = timeString.split(':')
diff --git a/Conversions/test/RailwayTimeConversion.test.js b/Conversions/test/RailwayTimeConversion.test.js
@@ -19,3 +19,7 @@ test('The RailwayTimeConversion of 11:20:00PM is 23:20:00', () => {
   const res = RailwayTimeConversion('11:20:00PM')
   expect(res).toEqual('23:20:00')
 })
+
+test('The RailwayTimeConversion throws when input is not a string', () => {
+  expect(() => RailwayTimeConversion(1120)).toThrowError()
+})

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`const RailwayTimeConversion = (timeString) => {`
`19`	`19`	`// firstly, check that input is a string or not.`
`20`	`20`	`if (typeof timeString !== 'string') {`
`21`		`- return new TypeError('Argument is not a string.')`
	`21`	`+ throw new TypeError('Argument is not a string.')`
`22`	`22`	`}`
`23`	`23`	`// split the string by ':' character.`
`24`	`24`	`const [hour, minute, secondWithShift] = timeString.split(':')`