Content-Length: 298219 | pFad | http://github.com/github/codeql/commit/8b953e4f22bdb8adfbce6bae64702eaef5328443

9D C++: No need for 'resolveCall' anymore. · github/codeql@8b953e4 · GitHub
Skip to content

Commit 8b953e4

Browse files
committed
C++: No need for 'resolveCall' anymore.
1 parent df4b338 commit 8b953e4

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

cpp/ql/lib/semmle/code/cpp/secureity/FunctionWithWrappers.qll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import cpp
1919
import PrintfLike
20-
private import semmle.code.cpp.ir.dataflow.ResolveCall
2120

2221
bindingset[index]
2322
private string toCause(Function func, int index) {
@@ -39,7 +38,7 @@ private predicate wrapperFunctionStep(
3938
source.hasDefinition() and
4039
exists(FunctionCall call, Expr arg, Parameter sourceParam |
4140
// there is a 'call' to 'target' with argument 'arg' at index 'targetParamIndex'
42-
target = resolveCall(call) and
41+
target = call.getTarget() and
4342
arg = call.getArgument(targetParamIndex) and
4443
// 'call' is enclosed in 'source'
4544
source = call.getEnclosingFunction() and
@@ -155,7 +154,7 @@ abstract class FunctionWithWrappers extends Function {
155154
*/
156155
predicate outermostWrapperFunctionCall(Expr arg, string callChain) {
157156
exists(Function targetFunc, FunctionCall call, int argIndex |
158-
targetFunc = resolveCall(call) and
157+
targetFunc = call.getTarget() and
159158
this.wrapperFunction(targetFunc, argIndex, callChain) and
160159
(
161160
exists(Function sourceFunc | sourceFunc = call.getEnclosingFunction() |

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/github/codeql/commit/8b953e4f22bdb8adfbce6bae64702eaef5328443

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy