fix out ref for linter

mattdholloway · mattdholloway · commit f47e5542e419 · 2025-07-15T13:35:49.000+01:00
diff --git a/pkg/github/discussions.go b/pkg/github/discussions.go
@@ -75,6 +75,8 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 				pagination.First = &defaultFirst
 			}
 
+			var out []byte
+
 			var discussions []*github.Discussion
 			if categoryID != nil {
 				// Query with category filter (server-side filtering)
@@ -124,11 +126,10 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 					discussions = append(discussions, di)
 				}
 
-				out, err := json.Marshal(discussions)
+				out, err = json.Marshal(discussions)
 				if err != nil {
 					return nil, fmt.Errorf("failed to marshal discussions: %w", err)
 				}
-				return mcp.NewToolResultText(string(out)), nil
 			} else {
 				// Query without category filter
 				var query struct {
@@ -176,12 +177,13 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp
 					discussions = append(discussions, di)
 				}
 
-				out, err := json.Marshal(discussions)
+				out, err = json.Marshal(discussions)
 				if err != nil {
 					return nil, fmt.Errorf("failed to marshal discussions: %w", err)
 				}
-				return mcp.NewToolResultText(string(out)), nil
 			}
+
+			return mcp.NewToolResultText(string(out)), nil
 		}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,8 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp`
`75`	`75`	`pagination.First = &defaultFirst`
`76`	`76`	`}`
`77`	`77`
	`78`	`+ var out []byte`
	`79`	`+`
`78`	`80`	`var discussions []*github.Discussion`
`79`	`81`	`if categoryID != nil {`
`80`	`82`	`// Query with category filter (server-side filtering)`
`@@ -124,11 +126,10 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp`
`124`	`126`	`discussions = append(discussions, di)`
`125`	`127`	`}`
`126`	`128`
`127`		`- out, err := json.Marshal(discussions)`
	`129`	`+ out, err = json.Marshal(discussions)`
`128`	`130`	`if err != nil {`
`129`	`131`	`return nil, fmt.Errorf("failed to marshal discussions: %w", err)`
`130`	`132`	`}`
`131`		`- return mcp.NewToolResultText(string(out)), nil`
`132`	`133`	`} else {`
`133`	`134`	`// Query without category filter`
`134`	`135`	`var query struct {`
`@@ -176,12 +177,13 @@ func ListDiscussions(getGQLClient GetGQLClientFn, t translations.TranslationHelp`
`176`	`177`	`discussions = append(discussions, di)`
`177`	`178`	`}`
`178`	`179`
`179`		`- out, err := json.Marshal(discussions)`
	`180`	`+ out, err = json.Marshal(discussions)`
`180`	`181`	`if err != nil {`
`181`	`182`	`return nil, fmt.Errorf("failed to marshal discussions: %w", err)`
`182`	`183`	`}`
`183`		`- return mcp.NewToolResultText(string(out)), nil`
`184`	`184`	`}`
	`185`	`+`
	`186`	`+ return mcp.NewToolResultText(string(out)), nil`
`185`	`187`	`}`
`186`	`188`	`}`
`187`	`189`