Content-Length: 314020 | pFad | http://github.com/github/github-mcp-server/pull/69/commits/b4e67723811058396fb3004bf96e87b4a06b488f

9D repository resource tests by mntlty · Pull Request #69 · github/github-mcp-server · GitHub
Skip to content

repository resource tests #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 2, 2025
Merged

repository resource tests #69

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
383c2d2
refactor to make testing easier
mntlty Apr 2, 2025
1cb52f9
not needed in handler func
mntlty Apr 2, 2025
2aa3002
small cleanup
mntlty Apr 2, 2025
d8b0056
create repository_resource_test
mntlty Apr 2, 2025
2fdda7c
remove chatty comments
mntlty Apr 2, 2025
9680b24
comment cleanup, function rename and some more tests
mntlty Apr 2, 2025
b4e6772
fix test for ubuntu runner
mntlty Apr 2, 2025
db7a180
remove it for now
mntlty Apr 2, 2025
02ebdc7
make required args explicit instead of panic
mntlty Apr 2, 2025
ad58220
more tests and cleanup
mntlty Apr 2, 2025
ede9f22
chore: use raw repo resources (#70)
SamMorrowDrums Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test for ubuntu runner
  • Loading branch information
@mntlty
mntlty committed Apr 2, 2025
commit b4e67723811058396fb3004bf96e87b4a06b488f
2 changes: 1 addition & 1 deletion pkg/github/repository_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
expectedDirContent := []mcp.TextResourceContents{
{
URI: "https://github.com/owner/repo/blob/main/README.md",
MIMEType: "",
MIMEType: "text/markdown; charset=utf-8",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frustratingly, this value exists on the ubuntu runner https://github.com/github/github-mcp-server/actions/runs/14212790977/job/39822938856?pr=69 and does not exist on the mac runner https://github.com/github/github-mcp-server/actions/runs/14212837651/job/39823067424?pr=69 , so one of the other fails. not sure how best to handle this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe another file type would be simpler

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe not, looks like "text/directory" is also an issue between the two runner types

Text: "README.md",
},
{
Expand Down
Loading








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/github/github-mcp-server/pull/69/commits/b4e67723811058396fb3004bf96e87b4a06b488f

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy