Content-Length: 2625 | pFad | http://github.com/gitpython-developers/GitPython/pull/1945.patch

thub.com From 58a9a58f58e6aae220efda8ce95bf4c2e0fd9ca0 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Wed, 24 Jul 2024 02:10:57 -0400 Subject: [PATCH 1/2] Use Alpine Linux in WSL on CI Some of the CI tests use WSL. This switches the WSL distribution from Debian to Alpine, which might be slightly faster. For the way it is being used here, the main expected speed improvement would be to how long the image would take to download, as Alpine is smaller. (The reason for this is thus unrelated to the reason for the Alpine docker CI test job added in #1826. There, the goal was to test on a wider variety of systems and environments, and that runs the whole test suite in Alpine. This just changes the WSL distro, used by a few tests on Windows, from Debian to Alpine.) Two things have changed that, taken together, have unblocked this: - https://github.com/Vampire/setup-wsl/issues/50 was fixed, so the action we are using is able to install Alpine Linux. See: https://github.com/gitpython-developers/GitPython/pull/1917#pullrequestreview-2081550232 - #1893 was fixed in #1888. So if switching the WSL distro from Debian to Alpine breaks any tests, including by making them fail in an unexpected way that raises the wrong exception, we are likely to find out. --- .github/workflows/pythonpackage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml index 031b0e6b2..61ab2206c 100644 --- a/.github/workflows/pythonpackage.yml +++ b/.github/workflows/pythonpackage.yml @@ -46,7 +46,7 @@ jobs: if: startsWith(matrix.os, 'windows') uses: Vampire/setup-wsl@v3.1.1 with: - distribution: Debian + distribution: Alpine - name: Prepare this repo for tests run: | From 055394a548d19dded2ad9791a208bbcc54879b14 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Wed, 24 Jul 2024 03:25:31 -0400 Subject: [PATCH 2/2] Install bash in WSL Alpine distro Because Alpine Linux does not ship with bash, and the tests that use WSL use it. --- .github/workflows/pythonpackage.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml index 61ab2206c..1902ecb19 100644 --- a/.github/workflows/pythonpackage.yml +++ b/.github/workflows/pythonpackage.yml @@ -47,6 +47,7 @@ jobs: uses: Vampire/setup-wsl@v3.1.1 with: distribution: Alpine + additional-packages: bash - name: Prepare this repo for tests run: |

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!