Content-Length: 2042 | pFad | http://github.com/gitpython-developers/GitPython/pull/911.patch

thub.com From 5e819da2a3701f6b689d315c8d0618f3f294aac8 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 21 Aug 2019 13:03:17 -0400 Subject: [PATCH] BF: remove ddt from requirements.txt since no ddt required at run time. Otherwise, since requirements.txt is loaded into install_requires, any installation which manages to miss installing ddt could cause setuptools to freak out. E.g. here is a traceback from running tests of datalad ====================================================================== ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata extractor_cls = extractors[mtype_key].load() File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load self.require(*args, **kwargs) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require items = working_set.resolve(reqs, env, installer, extras=self.extras) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve raise DistributionNotFound(req, requirers) pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPython in conda environment. Original commit 74a0507f4eb468b842d1f644f0e43196cda290a1 which added ddt there unfortunately does not state the reason so probably was just a slip --- requirements.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index 4b629cb4f..63d5ddfe7 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,2 +1 @@ gitdb2 (>=2.0.0) -ddt>=1.1.1

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!