Content-Length: 269850 | pFad | http://github.com/npm/run-script/pull/230/commits/989cb6f07450a48a88f0534c120b6b2a9753d3f4

D7 feat: use nodeGyp option by wraithgar · Pull Request #230 · npm/run-script · GitHub
Skip to content

feat: use nodeGyp option #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025
Merged

feat: use nodeGyp option #230

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
989cb6f
fix(make-spawn-args): allow overriding npm_ env vars via env
legobeat Sep 30, 2024
1017d3b
fixup: allow for nodeGyp to be passed as an option
wraithgar Mar 5, 2025
5e424eb
fixup: don't allow override of env variables set by this script expli…
wraithgar Mar 5, 2025
ec3fdb3
fixup: add tests
wraithgar Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(make-spawn-args): allow overriding npm_ env vars via env
  • Loading branch information
@legobeat @wraithgar
legobeat authored and wraithgar committed Mar 5, 2025
commit 989cb6f07450a48a88f0534c120b6b2a9753d3f4
2 changes: 1 addition & 1 deletion lib/make-spawn-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ const makeSpawnArgs = options => {
const spawnEnv = setPATH(path, binPaths, {
// we need to at least save the PATH environment var
...process.env,
...env,
npm_package_json: resolve(path, 'package.json'),
npm_lifecycle_event: event,
npm_lifecycle_script: cmd,
npm_config_node_gyp,
...env,
})

const spawnOpts = {
Expand Down








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/npm/run-script/pull/230/commits/989cb6f07450a48a88f0534c120b6b2a9753d3f4

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy