ci: stop testing against NodeJS v18 & fix sign benchmark (#330)

Uzlopak · wolfy1339 · web-flow · commit 33dc77e69c3f · 2025-05-20T11:41:02.000-04:00
BREAKING CHANGE: Drop support for NodeJS v18

---------

Co-authored-by: wolfy1339 &lt;4595477+wolfy1339@users.noreply.github.com&gt;
Co-authored-by: wolfy1339 &lt;webmaster@wolfy1339.com&gt;
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -52,9 +52,9 @@ jobs:
       fail-fast: false
       matrix:
         node_version:
-          - 18
           - 20
           - 22
+          - 24
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       - name: Use Node.js ${{ matrix.node_version }}
@@ -74,6 +74,8 @@ jobs:
       - browser
     steps:
       - run: exit 1
-        if: ${{ needs.lint.result != 'success' || needs.node.result != 'success' || needs.browser.result != 'success' || needs.deno.result != 'success' }}
+        if:
+          ${{ needs.lint.result != 'success' || needs.node.result != 'success' ||
+          needs.browser.result != 'success' || needs.deno.result != 'success' }}
       - run: echo ok
     if: ${{ always() }}
diff --git a/package.json b/package.json
@@ -73,6 +73,6 @@
     ]
   },
   "engines": {
-    "node": ">= 18"
+    "node": ">= 20"
   }
 }
diff --git a/scripts/build.mjs b/scripts/build.mjs
@@ -30,7 +30,7 @@ async function main() {
       outdir: "pkg/dist-node",
       bundle: true,
       platform: "node",
-      target: "node18",
+      target: "node20",
       format: "esm",
       ...sharedOptions,
     }),
diff --git a/test/benchmark-sign.bench.ts b/test/benchmark-sign.bench.ts
@@ -1,6 +1,6 @@
 import { bench, describe } from "vitest";
-import { verify as verifyNode } from "../src/index.ts";
-import { verify as verifyWeb } from "../src/web.ts";
+import { sign as signNode } from "../src/index.ts";
+import { sign as signWeb } from "../src/web.ts";
 import { toNormalizedJsonString } from "./common.ts";
 
 describe("sign", () => {

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,6 @@`
`73`	`73`	`]`
`74`	`74`	`},`
`75`	`75`	`"engines": {`
`76`		`- "node": ">= 18"`
	`76`	`+ "node": ">= 20"`
`77`	`77`	`}`
`78`	`78`	`}`