.empty() method works better than .size() == 0. Thanks to m.korotkov@postgrespro.ru for hint

nataraj-hates-MS-for-stealing-github · nataraj-hates-MS-for-stealing-github · commit 18e28f3b1aeb · 2025-05-16T06:54:23.000+03:00
diff --git a/blobstamper/stamp_json.cpp b/blobstamper/stamp_json.cpp
@@ -74,10 +74,10 @@ PoolPickerStamp::ExtractStr(std::shared_ptr<Blob> blob)
       }
     }
   }
-  if (unbounded_pool.size()>0)
+  if (! unbounded_pool.empty())
     target_pool = unbounded_pool;
 
-  if (target_pool.size() == 0)
+  if (target_pool.empty())
   {
     /* Most probably we are in out of data situation. Check it
      * and throw an exception. Or abort if something goes wrong
@@ -187,4 +187,3 @@ StampJSON::StampJSON()
   add_weak(stamp_a);
   add_weak(stamp_h);
 }
-

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,10 @@ PoolPickerStamp::ExtractStr(std::shared_ptr<Blob> blob)`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`	`}`
`77`		`- if (unbounded_pool.size()>0)`
	`77`	`+ if (! unbounded_pool.empty())`
`78`	`78`	`target_pool = unbounded_pool;`
`79`	`79`
`80`		`- if (target_pool.size() == 0)`
	`80`	`+ if (target_pool.empty())`
`81`	`81`	`{`
`82`	`82`	`/* Most probably we are in out of data situation. Check it`
`83`	`83`	`* and throw an exception. Or abort if something goes wrong`
`@@ -187,4 +187,3 @@ StampJSON::StampJSON()`
`187`	`187`	`add_weak(stamp_a);`
`188`	`188`	`add_weak(stamp_h);`
`189`	`189`	`}`
`190`		`-`