[PGPRO-5554] Make add_node get port via mm_get_free_port from Cluster.pm in order to fix rare error Could not bind IPv4 address in TAP tests. tags: multimaster

Alexey Masterov · Alexey Masterov · commit ef0c766728b5 · 2022-01-01T16:42:36.000+07:00
diff --git a/Cluster.pm b/Cluster.pm
@@ -340,7 +340,8 @@ sub add_node()
 {
 	my ($self) = @_;
 
-	my $new_node = get_new_node("node@{[$#{$self->{nodes}} + 2]}");
+	my $new_node = get_new_node("node@{[$#{$self->{nodes}} + 2]}",
+	(port => mm_get_free_port()));
 	push(@{$self->{nodes}}, $new_node);
 
 	return $#{$self->{nodes}};

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,8 @@ sub add_node()`
`340`	`340`	`{`
`341`	`341`	`my ($self) = @_;`
`342`	`342`
`343`		`- my $new_node = get_new_node("node@{[$#{$self->{nodes}} + 2]}");`
	`343`	`+ my $new_node = get_new_node("node@{[$#{$self->{nodes}} + 2]}",`
	`344`	`+ (port => mm_get_free_port()));`
`344`	`345`	`push(@{$self->{nodes}}, $new_node);`
`345`	`346`
`346`	`347`	`return $#{$self->{nodes}};`