Fix inadvertent semantics change in last patch to plug memory leaks.

robertmhaas · robertmhaas · commit 033b2343fae9 · 2014-01-21T11:42:37.000-05:00
Commit a5bca4e accidentally changed the semantics when the "skipping missing configuration file" is emitted, because it forced OK to true instead of leaving the value untouched. Spotted by Tom Lane.
diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc-file.l
@@ -476,7 +476,6 @@ ParseConfigFile(const char *config_file, const char *calling_file, bool strict,
 		ereport(LOG,
 				(errmsg("skipping missing configuration file \"%s\"",
 						abs_path)));
-		OK = true;
 		goto cleanup;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -476,7 +476,6 @@ ParseConfigFile(const char config_file, const char calling_file, bool strict,`
`476`	`476`	`ereport(LOG,`
`477`	`477`	`(errmsg("skipping missing configuration file \"%s\"",`
`478`	`478`	`abs_path)));`
`479`		`- OK = true;`
`480`	`479`	`goto cleanup;`
`481`	`480`	`}`
`482`	`481`