Fix latent costing error in create_merge_append_path.

tglsfdc · tglsfdc · commit 0832f2db68cc · 2016-11-19T15:06:45.000-05:00
create_merge_append_path should use the path rowcount it just computed,
not rel-&gt;tuples, for costing purposes.  Those numbers should always be
the same at present, but if we ever support parameterized MergeAppend
paths (a case this function is otherwise prepared for), the former would
be right and the latter wrong.

No need for back-patch since the problem is only latent.

Ashutosh Bapat

Discussion: &lt;CAFjFpRek+cLCnTo24youuGtsq4zRphEB8EUUPjDxZjnL4n4HYQ@mail.gmail.com&gt;
diff --git a/src/backend/optimizer/util/pathnode.c b/src/backend/optimizer/util/pathnode.c
@@ -1333,7 +1333,7 @@ create_merge_append_path(PlannerInfo *root,
 	cost_merge_append(&pathnode->path, root,
 					  pathkeys, list_length(subpaths),
 					  input_startup_cost, input_total_cost,
-					  rel->tuples);
+					  pathnode->path.rows);
 
 	return pathnode;
 }

Original file line number	Diff line number	Diff line change
`@@ -1333,7 +1333,7 @@ create_merge_append_path(PlannerInfo *root,`
`1333`	`1333`	`cost_merge_append(&pathnode->path, root,`
`1334`	`1334`	`pathkeys, list_length(subpaths),`
`1335`	`1335`	`input_startup_cost, input_total_cost,`
`1336`		`- rel->tuples);`
	`1336`	`+ pathnode->path.rows);`
`1337`	`1337`
`1338`	`1338`	`return pathnode;`
`1339`	`1339`	`}`