More cleanup of manipulations of hash indexes' hasho_flag field.

tglsfdc · tglsfdc · commit 083dc95a14c0 · 2017-04-15T14:11:15.000-04:00
Not much point in defining test macros for the flag bits if we
don't use 'em.

Amit Kapila
diff --git a/src/backend/access/hash/hash.c b/src/backend/access/hash/hash.c
@@ -897,7 +897,7 @@ hashbucketcleanup(Relation rel, Bucket cur_bucket, Buffer bucket_buf,
 			 * flag.
 			 */
 			if (tuples_removed && *tuples_removed > 0 &&
-				opaque->hasho_flag & LH_PAGE_HAS_DEAD_TUPLES)
+				H_HAS_DEAD_TUPLES(opaque))
 			{
 				opaque->hasho_flag &= ~LH_PAGE_HAS_DEAD_TUPLES;
 				clear_dead_marking = true;

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,7 @@ hashbucketcleanup(Relation rel, Bucket cur_bucket, Buffer bucket_buf,`
`897`	`897`	`* flag.`
`898`	`898`	`*/`
`899`	`899`	`if (tuples_removed && *tuples_removed > 0 &&`
`900`		`- opaque->hasho_flag & LH_PAGE_HAS_DEAD_TUPLES)`
	`900`	`+ H_HAS_DEAD_TUPLES(opaque))`
`901`	`901`	`{`
`902`	`902`	`opaque->hasho_flag &= ~LH_PAGE_HAS_DEAD_TUPLES;`
`903`	`903`	`clear_dead_marking = true;`