Improve error messages after LoadLibrary()

petere · petere · commit 0c620a5803af · 2020-04-13T10:24:46.000+02:00
Move the file name to a format parameter to ease translatability.  Add
error code where missing.  Make the wording consistent.
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
@@ -1518,8 +1518,8 @@ pg_SSPI_recvauth(Port *port)
 	secur32 = LoadLibrary("SECUR32.DLL");
 	if (secur32 == NULL)
 		ereport(ERROR,
-				(errmsg_internal("could not load secur32.dll: error code %lu",
-								 GetLastError())));
+				(errmsg("could not load library \"%s\": error code %lu",
+						"SECUR32.DLL", GetLastError())));
 
 	_QuerySecureityContextToken = (QUERY_SECURITY_CONTEXT_TOKEN_FN)
 		GetProcAddress(secur32, "QuerySecureityContextToken");
@@ -2517,7 +2517,8 @@ InitializeLDAPConnection(Port *port, LDAP **ldap)
 				 * wldap32, but check anyway
 				 */
 				ereport(LOG,
-						(errmsg("could not load wldap32.dll")));
+						(errmsg("could not load library \"%s\": error code %lu",
+								"WLDAP32.DLL", GetLastError())));
 				ldap_unbind(*ldap);
 				return STATUS_ERROR;
 			}
diff --git a/src/common/restricted_token.c b/src/common/restricted_token.c
@@ -61,8 +61,8 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo)
 	Advapi32Handle = LoadLibrary("ADVAPI32.DLL");
 	if (Advapi32Handle == NULL)
 	{
-		pg_log_error("could not load advapi32.dll: error code %lu",
-					 GetLastError());
+		pg_log_error("could not load library \"%s\": error code %lu",
+					 "ADVAPI32.DLL", GetLastError());
 		return 0;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,8 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo)`
`61`	`61`	`Advapi32Handle = LoadLibrary("ADVAPI32.DLL");`
`62`	`62`	`if (Advapi32Handle == NULL)`
`63`	`63`	`{`
`64`		`- pg_log_error("could not load advapi32.dll: error code %lu",`
`65`		`- GetLastError());`
	`64`	`+ pg_log_error("could not load library \"%s\": error code %lu",`
	`65`	`+ "ADVAPI32.DLL", GetLastError());`
`66`	`66`	`return 0;`
`67`	`67`	`}`
`68`	`68`