Remove useless duplicate call of defGetBoolean().

tglsfdc · tglsfdc · commit 0c66a164e751 · 2024-04-07T17:08:06.000-04:00
Seems to be a copy-and-paste error dating to dc21234. Noted while reviewing a related documentation patch.
diff --git a/src/backend/backup/basebackup.c b/src/backend/backup/basebackup.c
@@ -791,7 +791,6 @@ parse_basebackup_options(List *options, basebackup_options *opt)
 				ereport(ERROR,
 						(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
 						 errmsg("incremental backups cannot be taken unless WAL summarization is enabled")));
-			opt->incremental = defGetBoolean(defel);
 			o_incremental = true;
 		}
 		else if (strcmp(defel->defname, "max_rate") == 0)

Original file line number	Diff line number	Diff line change
`@@ -791,7 +791,6 @@ parse_basebackup_options(List options, basebackup_options opt)`
`791`	`791`	`ereport(ERROR,`
`792`	`792`	`(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),`
`793`	`793`	`errmsg("incremental backups cannot be taken unless WAL summarization is enabled")));`
`794`		`- opt->incremental = defGetBoolean(defel);`
`795`	`794`	`o_incremental = true;`
`796`	`795`	`}`
`797`	`796`	`else if (strcmp(defel->defname, "max_rate") == 0)`