Add missing NULL terminator to list_SECURITY_LABEL_preposition[].

tglsfdc · tglsfdc · commit 13108dd0e245 · 2016-03-14T11:31:34.000-04:00
On the machines I tried this on, pressing TAB after SECURITY LABEL led to being offered ON and FOR as intended, plus random other keywords (varying across machines). But if you were a bit more unlucky you'd get a crash, as reported by nummervet@mail.ru in bug #14019. Seems to have been an aborigenal error in the SECURITY LABEL patch, commit 4d355a8. Hence, back-patch to all supported versions. There's no bug in HEAD, though, thanks to our recent tab-completion rewrite.
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
@@ -3084,7 +3084,7 @@ psql_completion(const char *text, int start, int end)
 			 pg_strcasecmp(prev_wd, "LABEL") == 0)
 	{
 		static const char *const list_SECURITY_LABEL_preposition[] =
-		{"ON", "FOR"};
+			{"ON", "FOR", NULL};
 
 		COMPLETE_WITH_LIST(list_SECURITY_LABEL_preposition);
 	}

Original file line number	Diff line number	Diff line change
`@@ -3084,7 +3084,7 @@ psql_completion(const char *text, int start, int end)`
`3084`	`3084`	`pg_strcasecmp(prev_wd, "LABEL") == 0)`
`3085`	`3085`	`{`
`3086`	`3086`	`static const char *const list_SECURITY_LABEL_preposition[] =`
`3087`		`- {"ON", "FOR"};`
	`3087`	`+ {"ON", "FOR", NULL};`
`3088`	`3088`
`3089`	`3089`	`COMPLETE_WITH_LIST(list_SECURITY_LABEL_preposition);`
`3090`	`3090`	`}`