Fix bug in record_image_ops on big endian machines.

kgrittn · kgrittn · commit 15e46fd1dd77 · 2013-10-10T11:25:30.000-05:00
The buildfarm pointed out the problem.

Fix based on suggestion by Robert Haas.
diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c
@@ -1464,9 +1464,8 @@ record_image_cmp(PG_FUNCTION_ARGS)
 			}
 			else if (tupdesc1->attrs[i1]->attbyval)
 			{
-				cmpresult = memcmp(&(values1[i1]),
-								   &(values2[i2]),
-								   tupdesc1->attrs[i1]->attlen);
+				if (values1[i1] != values2[i2])
+					cmpresult = (values1[i1] < values2[i2]) ? -1 : 1;
 			}
 			else
 			{
@@ -1695,9 +1694,7 @@ record_image_eq(PG_FUNCTION_ARGS)
 			}
 			else if (tupdesc1->attrs[i1]->attbyval)
 			{
-				result = (memcmp(&(values1[i1]),
-								 &(values2[i2]),
-								 tupdesc1->attrs[i1]->attlen) == 0);
+				result = (values1[i1] == values2[i2]);
 			}
 			else
 			{

Original file line number	Diff line number	Diff line change
`@@ -1464,9 +1464,8 @@ record_image_cmp(PG_FUNCTION_ARGS)`
`1464`	`1464`	`}`
`1465`	`1465`	`else if (tupdesc1->attrs[i1]->attbyval)`
`1466`	`1466`	`{`
`1467`		`- cmpresult = memcmp(&(values1[i1]),`
`1468`		`- &(values2[i2]),`
`1469`		`- tupdesc1->attrs[i1]->attlen);`
	`1467`	`+ if (values1[i1] != values2[i2])`
	`1468`	`+ cmpresult = (values1[i1] < values2[i2]) ? -1 : 1;`
`1470`	`1469`	`}`
`1471`	`1470`	`else`
`1472`	`1471`	`{`
`@@ -1695,9 +1694,7 @@ record_image_eq(PG_FUNCTION_ARGS)`
`1695`	`1694`	`}`
`1696`	`1695`	`else if (tupdesc1->attrs[i1]->attbyval)`
`1697`	`1696`	`{`
`1698`		`- result = (memcmp(&(values1[i1]),`
`1699`		`- &(values2[i2]),`
`1700`		`- tupdesc1->attrs[i1]->attlen) == 0);`
	`1697`	`+ result = (values1[i1] == values2[i2]);`
`1701`	`1698`	`}`
`1702`	`1699`	`else`
`1703`	`1700`	`{`