Fix redundancy in error messages

petere · petere · commit 16a3415440ec · 2024-06-20T11:17:21.000+02:00
pg_log_error() already prints the program name, so we don't need to
print it again inside the message.
diff --git a/src/bin/pg_combinebackup/pg_combinebackup.c b/src/bin/pg_combinebackup/pg_combinebackup.c
@@ -212,7 +212,7 @@ main(int argc, char *argv[])
 
 	if (optind >= argc)
 	{
-		pg_log_error("%s: no input directories specified", progname);
+		pg_log_error("no input directories specified");
 		pg_log_error_hint("Try \"%s --help\" for more information.", progname);
 		exit(1);
 	}
diff --git a/src/bin/pg_walsummary/pg_walsummary.c b/src/bin/pg_walsummary/pg_walsummary.c
@@ -91,7 +91,7 @@ main(int argc, char *argv[])
 
 	if (optind >= argc)
 	{
-		pg_log_error("%s: no input files specified", progname);
+		pg_log_error("no input files specified");
 		pg_log_error_hint("Try \"%s --help\" for more information.", progname);
 		exit(1);
 	}

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ main(int argc, char *argv[])`
`212`	`212`
`213`	`213`	`if (optind >= argc)`
`214`	`214`	`{`
`215`		`- pg_log_error("%s: no input directories specified", progname);`
	`215`	`+ pg_log_error("no input directories specified");`
`216`	`216`	`pg_log_error_hint("Try \"%s --help\" for more information.", progname);`
`217`	`217`	`exit(1);`
`218`	`218`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ main(int argc, char *argv[])`
`91`	`91`
`92`	`92`	`if (optind >= argc)`
`93`	`93`	`{`
`94`		`- pg_log_error("%s: no input files specified", progname);`
	`94`	`+ pg_log_error("no input files specified");`
`95`	`95`	`pg_log_error_hint("Try \"%s --help\" for more information.", progname);`
`96`	`96`	`exit(1);`
`97`	`97`	`}`