nbtree: consistently use minoff variable.

petergeoghegan · petergeoghegan · commit 18ea6b3d0da3 · 2024-11-18T13:35:28.000-05:00
This was arguably an oversight in commit 29b64d1, which moved this code from nbtutils.c to its nbtsearch.c caller.
diff --git a/src/backend/access/nbtree/nbtsearch.c b/src/backend/access/nbtree/nbtsearch.c
@@ -1810,8 +1810,7 @@ _bt_readpage(IndexScanDesc scan, ScanDirection dir, OffsetNumber offnum,
 			 */
 			if (scan->ignore_killed_tuples && ItemIdIsDead(iid))
 			{
-				Assert(offnum >= P_FIRSTDATAKEY(opaque));
-				if (offnum > P_FIRSTDATAKEY(opaque))
+				if (offnum > minoff)
 				{
 					offnum = OffsetNumberPrev(offnum);
 					continue;

Original file line number	Diff line number	Diff line change
`@@ -1810,8 +1810,7 @@ _bt_readpage(IndexScanDesc scan, ScanDirection dir, OffsetNumber offnum,`
`1810`	`1810`	`*/`
`1811`	`1811`	`if (scan->ignore_killed_tuples && ItemIdIsDead(iid))`
`1812`	`1812`	`{`
`1813`		`- Assert(offnum >= P_FIRSTDATAKEY(opaque));`
`1814`		`- if (offnum > P_FIRSTDATAKEY(opaque))`
	`1813`	`+ if (offnum > minoff)`
`1815`	`1814`	`{`
`1816`	`1815`	`offnum = OffsetNumberPrev(offnum);`
`1817`	`1816`	`continue;`