Fix pg_dumpall option parsing: -i doesn't take an argument.

tglsfdc · tglsfdc · commit 19f2d6cdae2b · 2014-03-18T10:38:25.000-04:00
This used to work properly, but got fat-fingered in commit 3dee636. Per bug #9620 from Nicolas Payart.
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -195,7 +195,7 @@ main(int argc, char *argv[])
 
 	pgdumpopts = createPQExpBuffer();
 
-	while ((c = getopt_long(argc, argv, "acd:f:gh:i:l:oOp:rsS:tU:vwWx", long_options, &optindex)) != -1)
+	while ((c = getopt_long(argc, argv, "acd:f:gh:il:oOp:rsS:tU:vwWx", long_options, &optindex)) != -1)
 	{
 		switch (c)
 		{

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ main(int argc, char *argv[])`
`195`	`195`
`196`	`196`	`pgdumpopts = createPQExpBuffer();`
`197`	`197`
`198`		`- while ((c = getopt_long(argc, argv, "acd:f:gh:i:l:oOp:rsS:tU:vwWx", long_options, &optindex)) != -1)`
	`198`	`+ while ((c = getopt_long(argc, argv, "acd:f:gh:il:oOp:rsS:tU:vwWx", long_options, &optindex)) != -1)`
`199`	`199`	`{`
`200`	`200`	`switch (c)`
`201`	`201`	`{`