Fix comment in LockReleaseAll() on when locallock->nLock can be zero

hlinnaka · hlinnaka · commit 1fe0466cf2cb · 2024-11-04T15:31:46.000+02:00
We reach this case also e.g. when a deadlock is detected, not only when we run out of memory. Reviewed-by: Maxim Orlov Discussion: https://www.postgresql.org/message-id/7c2090cd-a72a-4e34-afaa-6dd2ef31440e@iki.fi
diff --git a/src/backend/storage/lmgr/lock.c b/src/backend/storage/lmgr/lock.c
@@ -2258,9 +2258,8 @@ LockReleaseAll(LOCKMETHODID lockmethodid, bool allLocks)
 	while ((locallock = (LOCALLOCK *) hash_seq_search(&status)) != NULL)
 	{
 		/*
-		 * If the LOCALLOCK entry is unused, we must've run out of shared
-		 * memory while trying to set up this lock.  Just forget the local
-		 * entry.
+		 * If the LOCALLOCK entry is unused, something must've gone wrong
+		 * while trying to acquire this lock.  Just forget the local entry.
 		 */
 		if (locallock->nLocks == 0)
 		{

Original file line number	Diff line number	Diff line change
`@@ -2258,9 +2258,8 @@ LockReleaseAll(LOCKMETHODID lockmethodid, bool allLocks)`
`2258`	`2258`	`while ((locallock = (LOCALLOCK *) hash_seq_search(&status)) != NULL)`
`2259`	`2259`	`{`
`2260`	`2260`	`/*`
`2261`		`- * If the LOCALLOCK entry is unused, we must've run out of shared`
`2262`		`- * memory while trying to set up this lock. Just forget the local`
`2263`		`- * entry.`
	`2261`	`+ * If the LOCALLOCK entry is unused, something must've gone wrong`
	`2262`	`+ * while trying to acquire this lock. Just forget the local entry.`
`2264`	`2263`	`*/`
`2265`	`2264`	`if (locallock->nLocks == 0)`
`2266`	`2265`	`{`