Fix deadlock at startup, if max_prepared_transactions is too small.

hlinnaka · hlinnaka · commit 223a946804aa · 2015-04-23T21:37:09.000+03:00
When the startup process recovers transactions by scanning pg_twophase directory, it should clear MyLockedGxact after it's done processing each transaction. Like we do during normal operation, at PREPARE TRANSACTION. Otherwise, if the startup process exits due to an error, it will try to clear the locking_backend field of the last recovered transaction. That's usually harmless, but if the error happens in MarkAsPreparing, while holding TwoPhaseStateLock, the shmem-exit hook will try to acquire TwoPhaseStateLock again, and deadlock with itself. This fixes bug #13128 reported by Grant McAlister. The bug was introduced by commit bb38fb0, so backpatch to all supported versions like that commit.
diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
@@ -1998,6 +1998,12 @@ RecoverPreparedTransactions(void)
 			if (InHotStandby)
 				StandbyReleaseLockTree(xid, hdr->nsubxacts, subxids);
 
+			/*
+			 * We're done with recovering this transaction. Clear MyLockedGxact,
+			 * like we do in PrepareTransaction() during normal operation.
+			 */
+			PostPrepare_Twophase();
+
 			pfree(buf);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1998,6 +1998,12 @@ RecoverPreparedTransactions(void)`
`1998`	`1998`	`if (InHotStandby)`
`1999`	`1999`	`StandbyReleaseLockTree(xid, hdr->nsubxacts, subxids);`
`2000`	`2000`
	`2001`	`+ /*`
	`2002`	`+ * We're done with recovering this transaction. Clear MyLockedGxact,`
	`2003`	`+ * like we do in PrepareTransaction() during normal operation.`
	`2004`	`+ */`
	`2005`	`+ PostPrepare_Twophase();`
	`2006`	`+`
`2001`	`2007`	`pfree(buf);`
`2002`	`2008`	`}`
`2003`	`2009`	`}`