basic_archive: Fix comments related to NO_INSTALLCHECK

michaelpq · michaelpq · commit 27f7f81e4c8d · 2023-12-20T08:39:54.000+09:00
These comments incorrectly referred to shared_preload_libraries as being required for the test to work. Thinko in commit c68a183. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACXpjFDiXf-L7AARQ4ppuxiDYSKZjyZb=wOa+cgg0zuWAw@mail.gmail.com
diff --git a/contrib/basic_archive/Makefile b/contrib/basic_archive/Makefile
@@ -5,8 +5,9 @@ PGFILEDESC = "basic_archive - basic archive module"
 
 REGRESS = basic_archive
 REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/basic_archive/basic_archive.conf
-# Disabled because these tests require "shared_preload_libraries=basic_archive",
-# which typical installcheck users do not have (e.g. buildfarm clients).
+
+# Disabled because these tests require special configuration, which
+# typical installcheck users do not have (e.g. buildfarm clients).
 NO_INSTALLCHECK = 1
 
 ifdef USE_PGXS
diff --git a/contrib/basic_archive/meson.build b/contrib/basic_archive/meson.build
@@ -27,8 +27,8 @@ tests += {
     'regress_args': [
       '--temp-config', files('basic_archive.conf'),
     ],
-    # Disabled because these tests require "shared_preload_libraries=basic_archive",
-    # which typical runningcheck users do not have (e.g. buildfarm clients).
+    # Disabled because these tests require special configuration, which
+    # typical installcheck users do not have (e.g. buildfarm clients).
     'runningcheck': false,
   },
 }
