Fix minor leak in pg_dump for ACCESS METHOD.

alvherre · alvherre · commit 37732a2555f1 · 2016-03-28T14:27:41.000-03:00
Bug reported by Coverity.

Author: Michaël Paquier
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -11580,6 +11580,7 @@ dumpAccessMethod(Archive *fout, AccessMethodInfo *aminfo)
 		default:
 			write_msg(NULL, "WARNING: invalid type %c of access method %s\n",
 					  aminfo->amtype, qamname);
+			pg_free(qamname);
 			destroyPQExpBuffer(q);
 			destroyPQExpBuffer(delq);
 			destroyPQExpBuffer(labelq);
@@ -11609,7 +11610,7 @@ dumpAccessMethod(Archive *fout, AccessMethodInfo *aminfo)
 				NULL, "",
 				aminfo->dobj.catId, 0, aminfo->dobj.dumpId);
 
-	free(qamname);
+	pg_free(qamname);
 
 	destroyPQExpBuffer(q);
 	destroyPQExpBuffer(delq);
