Commit 37ee4b7

committed

Restructure function-internal caching in the range type code.

Move the responsibility for caching specialized information about range types into the type cache, so that the catalog lookups only have to occur once per session. Rearrange APIs a bit so that fn_extra caching is actually effective in the GiST support code. (Use of OidFunctionCallN is bad enough for performance in itself, but it also prevents the function from exploiting fn_extra caching.) The range I/O functions are still not very bright about caching repeated lookups, but that seems like material for a separate patch. Also, avoid unnecessary use of memcpy to fetch/store the range type OID and flags, and don't use the full range_deserialize machinery when all we need to see is the flags value. Also fix API error in range_gist_penalty --- it was failing to set *penalty for any case involving an empty range.

1 parent ad50934 commit 37ee4b7Copy full SHA for 37ee4b7

5 files changed

+700

-602

lines changed

src
- backend/utils
  - adt
    - rangetypes.c
    - rangetypes_gist.c
  - cache
    - typcache.c
- include/utils
  - rangetypes.h
  - typcache.h

5 files changed

+700

-602

lines changed

Comments

(0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 37ee4b7

5 files changed

5 files changed

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

File tree

5 files changed

5 files changed

0 commit comments

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!