Content-Length: 257403 | pFad | http://github.com/postgrespro/postgres/commit/3a54f4a4944b849846c5a1494810ea06bd6601b7

D1 Remove ill-conceived Assertion in ProcessClientWriteInterrupt(). · postgrespro/postgres@3a54f4a · GitHub
Skip to content

Commit 3a54f4a

Browse files
committed
Remove ill-conceived Assertion in ProcessClientWriteInterrupt().
It's perfectly fine to have blocked interrupts when ProcessClientWriteInterrupt() is called. In fact it's commonly the case when emitting error reports. And we deal with that correctly. Even if that'd not be the case, it'd be a bad location for such a assertion. Because ProcessClientWriteInterrupt() is only called when the socket is blocked it's hard to hit. Per Heikki and buildfarm animals nightjar and dunlin.
1 parent 2505ce0 commit 3a54f4a

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/backend/tcop/postgres.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked)
571571
{
572572
int save_errno = errno;
573573

574-
Assert(InterruptHoldoffCount == 0 && CritSectionCount == 0);
575-
576574
/*
577575
* We only want to process the interrupt here if socket writes are
578576
* blocking to increase the chance to get an error message to the

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/postgrespro/postgres/commit/3a54f4a4944b849846c5a1494810ea06bd6601b7

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy