Avoid reading below the start of a stack variable in tokenize_file().

nmisch · nmisch · commit 3a5d0c55338e · 2013-06-12T19:50:52.000-04:00
We would wrongly overwrite the prior stack byte if it happened to
contain '\n' or '\r'.  New in 9.3, so no back-patch.
diff --git a/src/backend/libpq/hba.c b/src/backend/libpq/hba.c
@@ -411,9 +411,9 @@ tokenize_file(const char *filename, FILE *file,
 								line_number, filename)));
 
 		/* Strip trailing linebreak from rawline */
-		while (rawline[strlen(rawline) - 1] == '\n' ||
-			   rawline[strlen(rawline) - 1] == '\r')
-			rawline[strlen(rawline) - 1] = '\0';
+		lineptr = rawline + strlen(rawline) - 1;
+		while (lineptr >= rawline && (*lineptr == '\n' || *lineptr == '\r'))
+			*lineptr-- = '\0';
 
 		lineptr = rawline;
 		while (strlen(lineptr) > 0)
