Ensure that length argument of memcmp() isn't seen as negative.

tglsfdc · tglsfdc · commit 3b0ee7f583dc · 2022-02-15T17:28:17.000-05:00
I think this will shut up a weird warning from buildfarm member
serinus.  Perhaps it'd be better to change tsCompareString's
length arguments to unsigned, but that seems more invasive
than is justified.

Part of a general push to remove off-the-beaten-track warnings
where we can easily do so.
diff --git a/src/backend/utils/adt/tsvector_op.c b/src/backend/utils/adt/tsvector_op.c
@@ -1167,7 +1167,7 @@ tsCompareString(char *a, int lena, char *b, int lenb, bool prefix)
 	}
 	else
 	{
-		cmp = memcmp(a, b, Min(lena, lenb));
+		cmp = memcmp(a, b, Min((unsigned int) lena, (unsigned int) lenb));
 
 		if (prefix)
 		{

Original file line number	Diff line number	Diff line change
`@@ -1167,7 +1167,7 @@ tsCompareString(char a, int lena, char b, int lenb, bool prefix)`
`1167`	`1167`	`}`
`1168`	`1168`	`else`
`1169`	`1169`	`{`
`1170`		`- cmp = memcmp(a, b, Min(lena, lenb));`
	`1170`	`+ cmp = memcmp(a, b, Min((unsigned int) lena, (unsigned int) lenb));`
`1171`	`1171`
`1172`	`1172`	`if (prefix)`
`1173`	`1173`	`{`