Fix memory leak when inserting tuple at relation creation for CTAS

michaelpq · michaelpq · commit 414a9d3cf34c · 2019-02-27T14:14:06.000+09:00
The leak has been introduced by 763f2ed which has addressed the problem for transient tables, and forgot CREATE TABLE AS which shares a similar logic when receiving a new tuple to store into the newly-created relation. Author: Jeff Janes Discussion: https://postgr.es/m/CAMkU=1xZXtz3mziPEPD2Fubbas4G2RWkZm5HHABtfKVcbu1=Sg@mail.gmail.com
diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c
@@ -587,6 +587,9 @@ intorel_receive(TupleTableSlot *slot, DestReceiver *self)
 
 	/* We know this is a newly created relation, so there are no indexes */
 
+	/* Free the copied tuple. */
+	heap_freetuple(tuple);
+
 	return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -587,6 +587,9 @@ intorel_receive(TupleTableSlot slot, DestReceiver self)`
`587`	`587`
`588`	`588`	`/* We know this is a newly created relation, so there are no indexes */`
`589`	`589`
	`590`	`+ /* Free the copied tuple. */`
	`591`	`+ heap_freetuple(tuple);`
	`592`	`+`
`590`	`593`	`return true;`
`591`	`594`	`}`
`592`	`595`