Fix brown paper bag bug in 5c47c65.

robertmhaas · robertmhaas · commit 47f01d727e3a · 2023-12-19T15:00:23.000-05:00
The previous logic failed to work for anything other than the first segment of a relation. Report by Jakub Wartak. Patch by me. Discussion: http://postgr.es/m/CAKZiRmwd3KTNMQhm9Bv4oR_1uMehXroO6kGyJQkiw9DfM8cMwQ@mail.gmail.com
diff --git a/src/backend/storage/file/reinit.c b/src/backend/storage/file/reinit.c
@@ -431,7 +431,7 @@ parse_filename_for_nontemp_relation(const char *name, RelFileNumber *relnumber,
 	else
 	{
 		/* Reject leading zeroes, just like we do for RelFileNumber. */
-		if (name[0] < '1' || name[0] > '9')
+		if (name[1] < '1' || name[1] > '9')
 			return false;
 
 		errno = 0;

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ parse_filename_for_nontemp_relation(const char name, RelFileNumber relnumber,`
`431`	`431`	`else`
`432`	`432`	`{`
`433`	`433`	`/* Reject leading zeroes, just like we do for RelFileNumber. */`
`434`		`- if (name[0] < '1' \|\| name[0] > '9')`
	`434`	`+ if (name[1] < '1' \|\| name[1] > '9')`
`435`	`435`	`return false;`
`436`	`436`
`437`	`437`	`errno = 0;`