Fix compilation warning in xloginsert.c

michaelpq · michaelpq · commit 47f514dd9a00 · 2021-06-29T11:57:18.000+09:00
This is reproducible with gcc using at least -O0. The last checks validating the compression of a block could not be reached with this variable not set, but let's be clean. Oversight in 4035cd5, per buildfarm member lapwing.
diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c
@@ -863,7 +863,7 @@ XLogCompressBackupBlock(char *page, uint16 hole_offset, uint16 hole_length,
 						char *dest, uint16 *dlen)
 {
 	int32		orig_len = BLCKSZ - hole_length;
-	int32		len;
+	int32		len = -1;
 	int32		extra_bytes = 0;
 	char	   *source;
 	PGAlignedBlock tmp;

Original file line number	Diff line number	Diff line change
`@@ -863,7 +863,7 @@ XLogCompressBackupBlock(char *page, uint16 hole_offset, uint16 hole_length,`
`863`	`863`	`char dest, uint16 dlen)`
`864`	`864`	`{`
`865`	`865`	`int32 orig_len = BLCKSZ - hole_length;`
`866`		`- int32 len;`
	`866`	`+ int32 len = -1;`
`867`	`867`	`int32 extra_bytes = 0;`
`868`	`868`	`char *source;`
`869`	`869`	`PGAlignedBlock tmp;`