Make new authentication test case more robust.

tglsfdc · tglsfdc · commit 4d41823c5267 · 2020-09-04T21:01:58.000-04:00
I happened to notice that the new test case I added in b55b4da falls over if one runs "make check" repeatedly; though not in branches after v10. That's because it was assuming that tmp_check/pgpass wouldn't exist already. However, it's only been since v11 that the Makefiles forcibly remove all of tmp_check/ before starting a TAP run. This fix to unlink the file is therefore strictly necessary only in v10 ... but it seems wisest to do it across the board, rather than let the test rely on external logic to get the conditions right.
diff --git a/src/test/authentication/t/001_password.pl b/src/test/authentication/t/001_password.pl
@@ -107,6 +107,7 @@ sub test_role
 delete $ENV{"PGCHANNELBINDING"};
 $ENV{"PGPASSFILE"} = $pgpassfile;
 
+unlink($pgpassfile);
 append_to_file($pgpassfile, qq!
 # This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file.
 *:*:postgres:scram_role:pass:this is not part of the password.
