ECPG: Fix searching for quoted cursor names case-sensitively.

Michael Meskes · Michael Meskes · commit 51867a0f9b5c · 2013-11-27T11:02:13.000+01:00
Patch by Böszörményi Zoltán &lt;zb@cybertec.at&gt;
diff --git a/src/interfaces/ecpg/preproc/ecpg.addons b/src/interfaces/ecpg/preproc/ecpg.addons
@@ -290,7 +290,7 @@ ECPG: DeclareCursorStmtDECLAREcursor_namecursor_optionsCURSORopt_holdFORSelectSt
 		struct cursor *ptr, *this;
 		char *cursor_marker = $2[0] == ':' ? mm_strdup("$0") : mm_strdup($2);
 		char *comment, *c1, *c2;
-		int (* strcmp_fn)(const char *, const char *) = ($2[0] == ':' ? strcmp : pg_strcasecmp);
+		int (* strcmp_fn)(const char *, const char *) = (($2[0] == ':' || $2[0] == '"') ? strcmp : pg_strcasecmp);
 
 		for (ptr = cur; ptr != NULL; ptr = ptr->next)
 		{
diff --git a/src/interfaces/ecpg/preproc/ecpg.header b/src/interfaces/ecpg/preproc/ecpg.header
@@ -492,7 +492,7 @@ add_additional_variables(char *name, bool insert)
 {
 	struct cursor *ptr;
 	struct arguments *p;
-	int (* strcmp_fn)(const char *, const char *) = (name[0] == ':' ? strcmp : pg_strcasecmp);
+	int (* strcmp_fn)(const char *, const char *) = ((name[0] == ':' || name[0] == '"') ? strcmp : pg_strcasecmp);
 
 	for (ptr = cur; ptr != NULL; ptr=ptr->next)
 	{
diff --git a/src/interfaces/ecpg/preproc/ecpg.trailer b/src/interfaces/ecpg/preproc/ecpg.trailer
@@ -291,7 +291,7 @@ ECPGCursorStmt:  DECLARE cursor_name cursor_options CURSOR opt_hold FOR prepared
 		{
 			struct cursor *ptr, *this;
 			char *cursor_marker = $2[0] == ':' ? mm_strdup("$0") : mm_strdup($2);
-			int (* strcmp_fn)(const char *, const char *) = ($2[0] == ':' ? strcmp : pg_strcasecmp);
+			int (* strcmp_fn)(const char *, const char *) = (($2[0] == ':' || $2[0] == '"') ? strcmp : pg_strcasecmp);
 			struct variable *thisquery = (struct variable *)mm_alloc(sizeof(struct variable));
 			const char *con = connection ? connection : "NULL";
 			char *comment;

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ ECPG: DeclareCursorStmtDECLAREcursor_namecursor_optionsCURSORopt_holdFORSelectSt`
`290`	`290`	`struct cursor ptr, this;`
`291`	`291`	`char *cursor_marker = $2[0] == ':' ? mm_strdup("$0") : mm_strdup($2);`
`292`	`292`	`char comment, c1, *c2;`
`293`		`- int (* strcmp_fn)(const char , const char ) = ($2[0] == ':' ? strcmp : pg_strcasecmp);`
	`293`	`+ int (* strcmp_fn)(const char , const char ) = (($2[0] == ':' \|\| $2[0] == '"') ? strcmp : pg_strcasecmp);`
`294`	`294`
`295`	`295`	`for (ptr = cur; ptr != NULL; ptr = ptr->next)`
`296`	`296`	`{`
Original file line number	Diff line number	Diff line change
`@@ -492,7 +492,7 @@ add_additional_variables(char *name, bool insert)`
`492`	`492`	`{`
`493`	`493`	`struct cursor *ptr;`
`494`	`494`	`struct arguments *p;`
`495`		`- int (* strcmp_fn)(const char , const char ) = (name[0] == ':' ? strcmp : pg_strcasecmp);`
	`495`	`+ int (* strcmp_fn)(const char , const char ) = ((name[0] == ':' \|\| name[0] == '"') ? strcmp : pg_strcasecmp);`
`496`	`496`
`497`	`497`	`for (ptr = cur; ptr != NULL; ptr=ptr->next)`
`498`	`498`	`{`
Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ ECPGCursorStmt: DECLARE cursor_name cursor_options CURSOR opt_hold FOR prepared`
`291`	`291`	`{`
`292`	`292`	`struct cursor ptr, this;`
`293`	`293`	`char *cursor_marker = $2[0] == ':' ? mm_strdup("$0") : mm_strdup($2);`
`294`		`- int (* strcmp_fn)(const char , const char ) = ($2[0] == ':' ? strcmp : pg_strcasecmp);`
	`294`	`+ int (* strcmp_fn)(const char , const char ) = (($2[0] == ':' \|\| $2[0] == '"') ? strcmp : pg_strcasecmp);`
`295`	`295`	`struct variable thisquery = (struct variable )mm_alloc(sizeof(struct variable));`
`296`	`296`	`const char *con = connection ? connection : "NULL";`
`297`	`297`	`char *comment;`