Content-Length: 244423 | pFad | http://github.com/postgrespro/postgres/commit/52377bb81a2c0427d357bba71e7149de02d016ce

C7 Revert "Add TAP test to automate the equivalent of check_guc" · postgrespro/postgres@52377bb · GitHub

Commit 52377bb

committed

Revert "Add TAP test to automate the equivalent of check_guc"

This reverts commit b0a55f4, to remove for now the TAP test that did the equivalent of check_guc. The test has been using pg_config --sharedir to find the location of postgresql.conf.sample. While the buildfarm and normal build environments rather liked that, this proves to be an issue for Debian where pg_config is patched to not be relocatable, causing the test to fail. Rather than relying on pg_config, we'd better find the sample file based on its location from the source directory. However, this is also an issue as a TAP test only offers the build directory as of TESTDIR in the environment context, so this would fail with VPATH builds. Perhaps the source path could be provided additionally when running the TAP tests. Or perhaps we may be able to get away by just switching to a SQL approach, by using PG_ABS_SRCDIR but this is going to require some extra loops to get the sample file from the correct path in src/backend/. In any case, this needs more thoughts, so just revert the test case until something better is done about this relocation problem. Reported-by: Christopher Berg Discussion: https://postgr.es/m/YgYw25OXV5men8Fj@msg.df7cb.de

1 parent efa4a94 commit 52377bbCopy full SHA for 52377bb

1 file changed

+0

-110

lines changed

src/test/modules/test_misc/t
- 003_check_guc.pl

1 file changed

+0

-110

lines changed

`‎src/test/modules/test_misc/t/003_check_guc.pl`

This file was deleted.

Comments

(0)