psql: Fix memory leak with \gx used within a pipeline

michaelpq · michaelpq · commit 54d23601b978 · 2025-03-05T07:56:03.000+09:00
While inside a pipeline, \gx is currently forbidden and will make exec_command_g() exit early. There was a memory leak in this code path, so let's fix it. Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> Discussion: https://postgr.es/m/CAO6_XqqFVQjLjZQiL7xdwLpzZEy1ghO_JWvCFPM_OmwF9s7XdA@mail.gmail.com
diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c
@@ -1739,6 +1739,7 @@ exec_command_g(PsqlScanState scan_state, bool active_branch, const char *cmd)
 		{
 			pg_log_error("\\gx not allowed in pipeline mode");
 			clean_extended_state();
+			free(fname);
 			return PSQL_CMD_ERROR;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1739,6 +1739,7 @@ exec_command_g(PsqlScanState scan_state, bool active_branch, const char *cmd)`
`1739`	`1739`	`{`
`1740`	`1740`	`pg_log_error("\\gx not allowed in pipeline mode");`
`1741`	`1741`	`clean_extended_state();`
	`1742`	`+ free(fname);`
`1742`	`1743`	`return PSQL_CMD_ERROR;`
`1743`	`1744`	`}`
`1744`	`1745`