Avoid a possible relcache leak in get_object_address_attribute.

robertmhaas · robertmhaas · commit 5709b8acc67d · 2014-01-21T10:02:37.000-05:00
There's no apparent way to trigger this, so I'm not going to worry
about back-patching it for now.  But it's still wrong.

Marti Raudsepp
diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/objectaddress.c
@@ -1024,6 +1024,7 @@ get_object_address_attribute(ObjectType objtype, List *objname,
 		address.classId = RelationRelationId;
 		address.objectId = InvalidOid;
 		address.objectSubId = InvalidAttrNumber;
+		relation_close(relation, lockmode);
 		return address;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1024,6 +1024,7 @@ get_object_address_attribute(ObjectType objtype, List *objname,`
`1024`	`1024`	`address.classId = RelationRelationId;`
`1025`	`1025`	`address.objectId = InvalidOid;`
`1026`	`1026`	`address.objectSubId = InvalidAttrNumber;`
	`1027`	`+ relation_close(relation, lockmode);`
`1027`	`1028`	`return address;`
`1028`	`1029`	`}`
`1029`	`1030`