Another attempt at fixing memory leak in xlogreader.

hlinnaka · hlinnaka · commit 5e65f45c6eff · 2015-07-28T09:09:36.000+03:00
max_block_id is also reset between reading records.

Michael Paquier
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
@@ -124,7 +124,7 @@ XLogReaderFree(XLogReaderState *state)
 {
 	int			block_id;
 
-	for (block_id = 0; block_id <= state->max_block_id; block_id++)
+	for (block_id = 0; block_id <= XLR_MAX_BLOCK_ID; block_id++)
 	{
 		if (state->blocks[block_id].data)
 			pfree(state->blocks[block_id].data);

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ XLogReaderFree(XLogReaderState *state)`
`124`	`124`	`{`
`125`	`125`	`int block_id;`
`126`	`126`
`127`		`- for (block_id = 0; block_id <= state->max_block_id; block_id++)`
	`127`	`+ for (block_id = 0; block_id <= XLR_MAX_BLOCK_ID; block_id++)`
`128`	`128`	`{`
`129`	`129`	`if (state->blocks[block_id].data)`
`130`	`130`	`pfree(state->blocks[block_id].data);`