Declare the arguments of AllocateFile() as const char *, not char *.

tglsfdc · tglsfdc · commit 60d3c9fdf433 · 2006-03-04T21:32:47.000Z
This is consistent with the standard definition of fopen().
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.125 2006/01/17 23:52:31 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.126 2006/03/04 21:32:47 tgl Exp $
  *
  * NOTES:
  *
@@ -1236,7 +1236,7 @@ FileTruncate(File file, long offset)
  * Ideally this should be the *only* direct call of fopen() in the backend.
  */
 FILE *
-AllocateFile(char *name, char *mode)
+AllocateFile(const char *name, const char *mode)
 {
 	FILE	   *file;
 
diff --git a/src/include/storage/fd.h b/src/include/storage/fd.h
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/include/storage/fd.h,v 1.54 2005/10/15 02:49:46 momjian Exp $
+ * $PostgreSQL: pgsql/src/include/storage/fd.h,v 1.55 2006/03/04 21:32:46 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -71,7 +71,7 @@ extern long FileSeek(File file, long offset, int whence);
 extern int	FileTruncate(File file, long offset);
 
 /* Operations that allow use of regular stdio --- USE WITH CAUTION */
-extern FILE *AllocateFile(char *name, char *mode);
+extern FILE *AllocateFile(const char *name, const char *mode);
 extern int	FreeFile(FILE *file);
 
 /* Operations to allow use of the <dirent.h> library routines */

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.125 2006/01/17 23:52:31 tgl Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.126 2006/03/04 21:32:47 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES:`
`13`	`13`	`*`
`@@ -1236,7 +1236,7 @@ FileTruncate(File file, long offset)`
`1236`	`1236`	`* Ideally this should be the only direct call of fopen() in the backend.`
`1237`	`1237`	`*/`
`1238`	`1238`	`FILE *`
`1239`		`-AllocateFile(char name, char mode)`
	`1239`	`+AllocateFile(const char name, const char mode)`
`1240`	`1240`	`{`
`1241`	`1241`	`FILE *file;`
`1242`	`1242`