Fix unportable coding in BackgroundWorkerStateChange().

tglsfdc · tglsfdc · commit 643f75ca9b5b · 2014-02-15T17:15:05.000-05:00
PIDs aren't necessarily ints; our usual practice for printing them
is to explicitly cast to long.  Per buildfarm member rover_firefly.
diff --git a/src/backend/postmaster/bgworker.c b/src/backend/postmaster/bgworker.c
@@ -303,8 +303,8 @@ BackgroundWorkerStateChange(void)
 		rw->rw_worker.bgw_notify_pid = slot->worker.bgw_notify_pid;
 		if (!PostmasterMarkPIDForWorkerNotify(rw->rw_worker.bgw_notify_pid))
 		{
-			elog(DEBUG1, "worker notification PID %u is not valid",
-				 rw->rw_worker.bgw_notify_pid);
+			elog(DEBUG1, "worker notification PID %lu is not valid",
+				 (long) rw->rw_worker.bgw_notify_pid);
 			rw->rw_worker.bgw_notify_pid = 0;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -303,8 +303,8 @@ BackgroundWorkerStateChange(void)`
`303`	`303`	`rw->rw_worker.bgw_notify_pid = slot->worker.bgw_notify_pid;`
`304`	`304`	`if (!PostmasterMarkPIDForWorkerNotify(rw->rw_worker.bgw_notify_pid))`
`305`	`305`	`{`
`306`		`- elog(DEBUG1, "worker notification PID %u is not valid",`
`307`		`- rw->rw_worker.bgw_notify_pid);`
	`306`	`+ elog(DEBUG1, "worker notification PID %lu is not valid",`
	`307`	`+ (long) rw->rw_worker.bgw_notify_pid);`
`308`	`308`	`rw->rw_worker.bgw_notify_pid = 0;`
`309`	`309`	`}`
`310`	`310`