Convert misleading while loop into an if condition

david-rowley · david-rowley · commit 6cb93beddd33 · 2021-05-14T12:26:11.000+12:00
This seems to be leftover from ea15e18 and from when we used to evaluate SRFs at each node. Since there is an unconditional "return" at the end of the loop body, only 1 loop is ever possible, so we can just change this into an if condition. There is no actual bug being fixed here so no back-patch. It seems fine to just fix this anomaly in master only. Author: Greg Nancarrow Discussion: https://postgr.es/m/CAJcOf-d7T1q0az-D8evWXnsuBZjigT04WkV5hCAOEJQZRWy28w@mail.gmail.com
diff --git a/src/backend/executor/nodeResult.c b/src/backend/executor/nodeResult.c
@@ -103,7 +103,7 @@ ExecResult(PlanState *pstate)
 	 * called, OR that we failed the constant qual check. Either way, now we
 	 * are through.
 	 */
-	while (!node->rs_done)
+	if (!node->rs_done)
 	{
 		outerPlan = outerPlanState(node);
 

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ ExecResult(PlanState *pstate)`
`103`	`103`	`* called, OR that we failed the constant qual check. Either way, now we`
`104`	`104`	`* are through.`
`105`	`105`	`*/`
`106`		`- while (!node->rs_done)`
	`106`	`+ if (!node->rs_done)`
`107`	`107`	`{`
`108`	`108`	`outerPlan = outerPlanState(node);`
`109`	`109`