A minor simplification for List manipulation

petere · petere · commit 6d56c501a75f · 2023-07-03T11:39:03.000+02:00
Fix one place that was using lfirst(list_head(list)) by using linitial(list) instead. They are equivalent but the latter is simpler. We did the same in 9d299a4. Author: Richard Guo <guofenglinux@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/CAMbWs49dJnpezDQDDxCPKq7+=_3NyqLqGqnhqCjd+dYe4MS15w@mail.gmail.com
diff --git a/src/backend/rewrite/rewriteSearchCycle.c b/src/backend/rewrite/rewriteSearchCycle.c
@@ -523,7 +523,7 @@ rewriteSearchAndCycle(CommonTableExpr *cte)
 
 			fexpr = makeFuncExpr(F_INT8INC, INT8OID, list_make1(fs), InvalidOid, InvalidOid, COERCE_EXPLICIT_CALL);
 
-			lfirst(list_head(search_col_rowexpr->args)) = fexpr;
+			linitial(search_col_rowexpr->args) = fexpr;
 
 			texpr = (Expr *) search_col_rowexpr;
 		}

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ rewriteSearchAndCycle(CommonTableExpr *cte)`
`523`	`523`
`524`	`524`	`fexpr = makeFuncExpr(F_INT8INC, INT8OID, list_make1(fs), InvalidOid, InvalidOid, COERCE_EXPLICIT_CALL);`
`525`	`525`
`526`		`- lfirst(list_head(search_col_rowexpr->args)) = fexpr;`
	`526`	`+ linitial(search_col_rowexpr->args) = fexpr;`
`527`	`527`
`528`	`528`	`texpr = (Expr *) search_col_rowexpr;`
`529`	`529`	`}`