Handle EACCES errors from kevent() better.

macdice · macdice · commit 70516a178ad0 · 2020-10-15T18:34:21.000+13:00
While registering for postmaster exit events, we have to handle a couple of edge cases where the postmaster is already gone. Commit 815c2f0 missed one: EACCES must surely imply that PostmasterPid no longer belongs to our postmaster process (or alternatively an unexpected permissions model has been imposed on us). Like ESRCH, this should be treated as a WL_POSTMASTER_DEATH event, rather than being raised with ereport(). No known problems reported in the wild. Per code review from Tom Lane. Back-patch to 13. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/3624029.1602701929%40sss.pgh.pa.us
diff --git a/src/backend/storage/ipc/latch.c b/src/backend/storage/ipc/latch.c
@@ -1148,7 +1148,8 @@ WaitEventAdjustKqueue(WaitEventSet *set, WaitEvent *event, int old_events)
 
 	if (rc < 0)
 	{
-		if (event->events == WL_POSTMASTER_DEATH && errno == ESRCH)
+		if (event->events == WL_POSTMASTER_DEATH &&
+			(errno == ESRCH || errno == EACCES))
 			set->report_postmaster_not_running = true;
 		else
 			ereport(ERROR,

Original file line number	Diff line number	Diff line change
`@@ -1148,7 +1148,8 @@ WaitEventAdjustKqueue(WaitEventSet set, WaitEvent event, int old_events)`
`1148`	`1148`
`1149`	`1149`	`if (rc < 0)`
`1150`	`1150`	`{`
`1151`		`- if (event->events == WL_POSTMASTER_DEATH && errno == ESRCH)`
	`1151`	`+ if (event->events == WL_POSTMASTER_DEATH &&`
	`1152`	`+ (errno == ESRCH \|\| errno == EACCES))`
`1152`	`1153`	`set->report_postmaster_not_running = true;`
`1153`	`1154`	`else`
`1154`	`1155`	`ereport(ERROR,`