CREATE INDEX: do not update stats during binary upgrade.

jeff-davis · jeff-davis · commit 71b66171d045 · 2024-04-03T16:12:45.000-07:00
During binary upgrade, indexes are created before the data is moved into place, so it will always be zero. This is not currently a major problem, but will be when we try to preserve statistics during upgrade. Author: Corey Huinker Discussion: https://postgr.es/m/CADkLM=daPdFB8V0tgFxK-dLowFsAEzWRWJHyxij7BG3kBjcouA@mail.gmail.com
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
@@ -2874,7 +2874,11 @@ index_update_stats(Relation rel,
 		dirty = true;
 	}
 
-	if (reltuples >= 0)
+	/*
+	 * Avoid updating statistics during binary upgrade, because the indexes
+	 * are created before the data is moved into place.
+	 */
+	if (reltuples >= 0 && !IsBinaryUpgrade)
 	{
 		BlockNumber relpages = RelationGetNumberOfBlocks(rel);
 		BlockNumber relallvisible;

Original file line number	Diff line number	Diff line change
`@@ -2874,7 +2874,11 @@ index_update_stats(Relation rel,`
`2874`	`2874`	`dirty = true;`
`2875`	`2875`	`}`
`2876`	`2876`
`2877`		`- if (reltuples >= 0)`
	`2877`	`+ /*`
	`2878`	`+ * Avoid updating statistics during binary upgrade, because the indexes`
	`2879`	`+ * are created before the data is moved into place.`
	`2880`	`+ */`
	`2881`	`+ if (reltuples >= 0 && !IsBinaryUpgrade)`
`2878`	`2882`	`{`
`2879`	`2883`	`BlockNumber relpages = RelationGetNumberOfBlocks(rel);`
`2880`	`2884`	`BlockNumber relallvisible;`