Don't adjust ressortgroupref in generate_setop_child_grouplist()

david-rowley · david-rowley · commit 7487044d6ccf · 2024-04-03T15:39:29.000+13:00
This is already done inside assignSortGroupRef(), therefore is redundant. Oversight from 66c0185. Reported-by: Tom Lane Discussion: https://postgr.es/m/3703023.1711654574@sss.pgh.pa.us
diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
@@ -7959,7 +7959,6 @@ generate_setop_child_grouplist(SetOperationStmt *op, List *targetlist)
 
 		/* assign a tleSortGroupRef, or reuse the existing one */
 		sgc->tleSortGroupRef = assignSortGroupRef(tle, targetlist);
-		tle->ressortgroupref = sgc->tleSortGroupRef;
 	}
 	Assert(lg == NULL);
 	return grouplist;

Original file line number	Diff line number	Diff line change
`@@ -7959,7 +7959,6 @@ generate_setop_child_grouplist(SetOperationStmt op, List targetlist)`
`7959`	`7959`
`7960`	`7960`	`/* assign a tleSortGroupRef, or reuse the existing one */`
`7961`	`7961`	`sgc->tleSortGroupRef = assignSortGroupRef(tle, targetlist);`
`7962`		`- tle->ressortgroupref = sgc->tleSortGroupRef;`
`7963`	`7962`	`}`
`7964`	`7963`	`Assert(lg == NULL);`
`7965`	`7964`	`return grouplist;`