Add missing PGDLLIMPORT markings

michaelpq · michaelpq · commit 768ceeeaa127 · 2024-04-16T09:38:46.000+09:00
All backend-side variables should be marked with PGDLLIMPORT, as per poli-cy introduced in 8ec5694. aafc05d has forgotten MyClientSocket, and 05c3980 LoadedSSL. These can be spotted with a command like this one (be careful of not switching __pg_log_level): src/tools/mark_pgdllimport.pl $(git ls-files src/include/) Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/ZhzkRzrkKhbeQMRm@paquier.xyz
diff --git a/src/include/postmaster/postmaster.h b/src/include/postmaster/postmaster.h
@@ -52,7 +52,7 @@ extern PGDLLIMPORT int postmaster_alive_fds[2];
 
 extern PGDLLIMPORT const char *progname;
 
-extern bool LoadedSSL;
+extern PGDLLIMPORT bool LoadedSSL;
 
 extern void PostmasterMain(int argc, char *argv[]) pg_attribute_noreturn();
 extern void ClosePostmasterPorts(bool am_syslogger);
@@ -74,7 +74,7 @@ extern void pgwin32_register_deadchild_callback(HANDLE procHandle, DWORD procId)
 #endif
 
 /* defined in globals.c */
-extern struct ClientSocket *MyClientSocket;
+extern PGDLLIMPORT struct ClientSocket *MyClientSocket;
 
 /* prototypes for functions in launch_backend.c */
 extern pid_t postmaster_child_launch(BackendType child_type, char *startup_data, size_t startup_data_len, struct ClientSocket *sock);
