Check dup2() results in syslogger

sfrost · sfrost · commit 790eaa699e4a · 2014-01-26T16:26:18.000-05:00
Consistently check the dup2() call results throughout syslogger.c.
It's pretty unlikely that they'll error out, but if they do,
ereport(FATAL) instead of blissfully continuing on.

Spotted by the Coverity scanner.
diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
@@ -210,8 +210,14 @@ SysLoggerMain(int argc, char *argv[])
 		close(fileno(stderr));
 		if (fd != -1)
 		{
-			dup2(fd, fileno(stdout));
-			dup2(fd, fileno(stderr));
+			if (dup2(fd, fileno(stdout)) < 0)
+					ereport(FATAL,
+							(errcode_for_file_access(),
+							 errmsg("could not redirect stdout: %m")));
+			if (dup2(fd, fileno(stderr)) < 0)
+					ereport(FATAL,
+							(errcode_for_file_access(),
+							 errmsg("could not redirect stderr: %m")));
 			close(fd);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -210,8 +210,14 @@ SysLoggerMain(int argc, char *argv[])`
`210`	`210`	`close(fileno(stderr));`
`211`	`211`	`if (fd != -1)`
`212`	`212`	`{`
`213`		`- dup2(fd, fileno(stdout));`
`214`		`- dup2(fd, fileno(stderr));`
	`213`	`+ if (dup2(fd, fileno(stdout)) < 0)`
	`214`	`+ ereport(FATAL,`
	`215`	`+ (errcode_for_file_access(),`
	`216`	`+ errmsg("could not redirect stdout: %m")));`
	`217`	`+ if (dup2(fd, fileno(stderr)) < 0)`
	`218`	`+ ereport(FATAL,`
	`219`	`+ (errcode_for_file_access(),`
	`220`	`+ errmsg("could not redirect stderr: %m")));`
`215`	`221`	`close(fd);`
`216`	`222`	`}`
`217`	`223`	`}`